Re: [PATCH] cris: lower the printk level in cris serial driver

[Alan Cox]

> > Â Â Â Âif (info->recv_cnt + recvl > 65536) {
> > - Â Â Â Â Â Â Â printk(KERN_CRIT
> > + Â Â Â Â Â Â Â printk(KERN_INFO
> > Â Â Â Â Â Â Â Â Â Â Â "%s: Too much pending incoming serial data! Dropping %u bytes.\n", __func__, recvl);
> > Â Â Â Â Â Â Â Âreturn 0;
> > Â Â Â Â}
> 
> I think dropped data warrants KERN_WARN.

If you have an overflow you want to push the relevant tty flag into the
queue. I'm not sure a printk is that useful - end users of embedded
devices (or even PC desktops) won't see it anyway and if you have serial
console it can actually make things worse

Plus of course it's not rate limited here so its a log wiping vector ...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/