Re: [PATCH v6 00/10] crc32

[Joakim Tjernlund]

Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote on 2011/09/03 01:50:20:
>
> On Wed, 31 Aug 2011 17:29:32 -0500
> Bob Pearson <rpearson@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> > This is an attempt to resolve all the issues that were left in the last review.
> > There is one proposed change that is still causing a difference of opinion
> > which has to do with the form of the loops and their performance on x86 and ppc
> > This version has the change to the form that runs faster on x86 as an ifdef.
> >
> > This patch series provides improved performance for computing the crc32
> > polynomial on common hardware by adding the Slicing-by-8 algorithm to the
> > existing algorithms already included. The new algorithm is very closely
> > related to the existing algorithm so the extension requires small changes
> > to implement.  Additionally it cleans up some warnings in the existing
> > code and adds a kernel mode optional self test to replace the existing
> > user mode self test.
> >
> > A description of the existing and new algorithm is included in
> > Documentation/crc32.txt.
>
> So...  are the crc wars over yet?  I hope it's safe to look at the
> patches now ;)

Hehe, not sure :) I got side tracked with other things and haven't had time
to look into this last series.

>
> Please see Documentation/SubmittingPatches Section 15's discussion of
> patch Subject: lines.
>
> Is there any code in the kernel which uses the crc code so much that we
> actually care about its performance?

Sure, JFFS2/UBIFS/LogFS uses it heavily. SCTP too although it uses CRC32c, the
SW impl. of CRC32c should be moved to the same place as crc32.c

 Jocke

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/