Re: [PATCH 1/2] mm: Cleanup clearing of BDI_pending bit inbdi_forker_thread()

[Jan Kara]

On Sun 04-09-11 12:13:05, Wu Fengguang wrote:
> On Sun, Sep 04, 2011 at 11:04:42AM +0800, Wu Fengguang wrote:
> > On Sat, Sep 03, 2011 at 06:54:18AM +0800, Jan Kara wrote:
> > > bdi_forker_thread() clears BDI_pending bit at the end of the main loop.
> > > However clearing of this bit must not be done in some cases which is handled by
> > > calling 'continue' from switch statement. That's kind of unusual construct and
> > > without a good reason so change the function into more intuitive code flow.
> > > 
> > > CC: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> > > CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > 
> > It's pure code refactor.
> > 
> > Reviewed-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> 
> But I do suspect it will slightly increase the code size.
> What do you think?
  I haven't checked, maybe it will if the compiler is not clever enough to
merge two occurences of the function which is going to be inlined. But the
overhead will be really small and the code is not really performance critical
so I think clarity has priority.

								Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/