Re: [PATCH 4/4] posix-timers: turn it_signal into it_valid flag

[Eric Dumazet]

Le mardi 06 septembre 2011 Ã 20:47 +0200, Thomas Gleixner a Ãcrit :
> On Tue, 6 Sep 2011, Eric Dumazet wrote:
> 
> > Le mardi 06 septembre 2011 Ã 16:51 +0200, Oleg Nesterov a Ãcrit :
> > > On 09/05, Andi Kleen wrote:
> > > >
> > > > > I forgot everything I knew about ->it_requeue_pending logic, but it
> > > > > seems to me that do_schedule_next_timer()->lock_timer() can find and
> > > > > lock successfully the wrong timer. Another thread can do timer_delete()
> > > > > and then re-create the timer with the same id.
> > > >
> > > > Do you mean after my patches or even before?
> > > 
> > > Ah, sorry for confusion.
> > > 
> > > Before. And after. IOW, I think this has nothing to do with your patches.
> > > 
> > 
> > Hmm, you mean following patch is needed ?
> > 
> > Before release of timer id to idr pool, we should make sure
> > do_schedule_next_timer() wont be called, or it could find another timer
> > reusing the just released id.
> 
> I don't see how that makes it sure. If the signal is queued, then it
> stays queued and the put_pid() has no effect either.

Indeed, this is a real old bug then...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/