Re: [PATCH] sound: Fix race condition in the pcm_lib"wait for space loop

[Andrew Morton]

On Mon, 5 Sep 2011 09:49:47 -0700
Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> >From 2e37f0a4b2289962e1a45d8e02f8a7f7adad619f Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> Date: Mon, 5 Sep 2011 09:40:18 -0700
> Subject: [PATCH] sound: Fix race condition in the pcm_lib "wait for space" loop
> 
> The wait_for_avail() function in pcm_lib.c has a race in it (observed in
> practice by an Intel validation group).
> 
> The function is supposed to return once space in the buffer has become
> available, or if some timeout happens.  The entity that creates space (irq
> handler of sound driver and some such) will do a wake up on a waitqueue that
> this function registers for.
> 
> However there are two races in the existing code
> 1) If space became available between the caller noticing there was no space and
>    this function actually sleeping, the wakeup is missed and the timeout
>    condition will happen instead
> 2) If a wakeup happened but not sufficient space became available, the code will loop
>    again and wait for more space. However, if the second wake comes in prior
>    to hitting the schedule_timeout_interruptible(), it will be missed, and
>    potentially you'll wait out until the timeout happens.
> 
> The fix consists of using more careful setting of the current state (so that
> if a wakeup happens in the main loop window, the schedule_timeout() falls
> through) and by checking for available space prior to going into the
> schedule_timeout() loop, but after being on the waitqueue and having the
> state set to interruptible.
> 
> ...
>
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -1761,6 +1761,10 @@ static int wait_for_avail(struct snd_pcm_substream *substream,
>  	snd_pcm_uframes_t avail = 0;
>  	long wait_time, tout;
>  
> +	init_waitqueue_entry(&wait, current);
> +	add_wait_queue(&runtime->tsleep, &wait);
> +	set_current_state(TASK_INTERRUPTIBLE);

Well, this isn't very good either.  if a wakeup gets delivered to
runtime->tsleep before the set_current_state(), this process will go
ahead and incorrectly set itself into TASK_INTERRUPTIBLE state.

That looks like it will be dont-care/cant-happen in this case, but it's
setting a bad example.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/