Re: [PATCH 1/2] staging: zram: fix zram locking

From: Nitin Gupta
Date: Wed Sep 07 2011 - 21:35:13 EST

Next message: Barry Song: "Re: [PATCH] dmaengine: add CSR SiRFprimaII DMAC driver"
Previous message: Nitin Gupta: "Re: [PATCH 3/4] Simplify zram disk resizing interface"
In reply to: Jerome Marchand: "[PATCH 2/2] staging: zram: prevent accessing an unallocated table when init fails early"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 09/06/2011 09:02 AM, Jerome Marchand wrote:

Currently init_lock only prevents concurrent execution of zram_init_device()
and zram_reset_device() but not zram_make_request() nor sysfs store functions.

zram_make_request() initializes the device first time it is used and from then on no sysfs config writes are allowed till the device is reset -- for example, you cannot change disksize while a disk is in initialized state. So, I could not understand why we need to protect zram_make_request vs sysfs stores.

Thanks,
Nitin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Barry Song: "Re: [PATCH] dmaengine: add CSR SiRFprimaII DMAC driver"
Previous message: Nitin Gupta: "Re: [PATCH 3/4] Simplify zram disk resizing interface"
In reply to: Jerome Marchand: "[PATCH 2/2] staging: zram: prevent accessing an unallocated table when init fails early"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]