[PATCH Resend][Trivial] Match on_each_cpu behaviour on UP to SMP

From: Gilad Ben-Yossef
Date: Thu Sep 08 2011 - 02:58:12 EST


The comment in the SMP implementation of on_each_cpu says:
"May be used during early boot while
early_boot_irqs_disabled is set. Use local_irq_save/restore() instead
of local_irq_disable/enable()."

but the existing UP macro version uses local_irq_disable/enable().

Do the safe thing - make the UP version match the SMP one.

Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>
CC: Jiri Kosina <trivial@xxxxxxxxxx>
---
include/linux/smp.h | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/smp.h b/include/linux/smp.h
index 8cc38d3..7c9b9d4 100644
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -127,9 +127,10 @@ static inline int up_smp_call_function(smp_call_func_t func, void *info)
(up_smp_call_function(func, info))
#define on_each_cpu(func,info,wait) \
({ \
- local_irq_disable(); \
+ unsigned long __flags; \
+ local_irq_save(__flags); \
func(info); \
- local_irq_enable(); \
+ local_irq_retore(__flags); \
0; \
})
static inline void smp_send_reschedule(int cpu) { }
--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/