Re: [PATCH v3 1/2] xen: add an "highmem" parameter toalloc_xenballooned_pages

[Stefano Stabellini]

On Wed, 7 Sep 2011, Jeremy Fitzhardinge wrote:
> > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> > index f914b26..07a56c2 100644
> > --- a/drivers/xen/gntdev.c
> > +++ b/drivers/xen/gntdev.c
> > @@ -123,7 +123,7 @@ static struct grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count)
> >  	    NULL == add->pages)
> >  		goto err;
> >  
> > -	if (alloc_xenballooned_pages(count, add->pages))
> > +	if (alloc_xenballooned_pages(count, add->pages, 0 /* lowmem */))
> 
> If the parameter is "bool" you should pass true/false.  But it might be
> better to just make it take a GFP_ constant directly.

I would rather have a bool to be consistent with the other balloon
interfaces.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/