Re: [PATCH] usb: add new usb gadget for ACM and mass storage

[Klaus Schwarzkopf]

Am 08.09.2011 21:11, schrieb Greg KH:
> On Thu, Sep 08, 2011 at 08:24:47PM +0200, Klaus Schwarzkopf wrote:
> > This driver provides two functions in one configuration:
> > a mass storage, and a CDC ACM (serial port) link.
> > Heavily based on multi.c and cdc2.c
>
> I thought the "composite" framework make it so that drivers like this
> were no longer needed.  Or am I mistaken somehow?


The "composite" framework enabled drivers with two or more functions. 
For example the cdc2.c driver have support for ECM and ACM.


> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
>
> Do you really mean "any later version"?


The acm_ms.c file is heavly based on the cdc2.c file with this 
paragraph. Can i change this without breaking the license?


> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
>
> These two paragraphs are not needed, and the address is a very bad idea
> to include in any file as it changes over time and I don't think you
> want to keep up with the address location of the FSF for the next 40+
> years.
>
> As an example of this, I am starting to get patches from the FSF to fix
> up old addresses, 10 years after moving their office...

OK, i remove this lines.

Can i remove this lines in all files of the directory drivers/usb/gadget?


+#define CDC_VENDOR_NUM	0x1d6b	/* Linux Foundation */
+#define CDC_PRODUCT_NUM	0x0106	/* CDC Composite: ACM + MS*/

I used the next free device ID from http://www.linux-usb.org/usb.ids, is 
this ok?

Anything else to do?


Regards,

Klaus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/