Re: [PATCH 1/2] regmap: Support half writes and padding between registerand value.

[Jonathan Cameron]

On 09/09/11 17:14, Mark Brown wrote:
> On Fri, Sep 09, 2011 at 10:44:57AM +0100, Jonathan Cameron wrote:
>> On 09/08/11 17:27, Mark Brown wrote:
> 
>>> Please do a patch adding padding separately - that does seem like a
>>> useful thing to have in general, with the option of having it both
>>> before and after the register.
> 
>> Happy to do it separately, but not sure the padding before the register
>> address is a real use case.  You pad after to give the device time to
>> respond, before doesn't make much sense to me on a register based device...
>> I'll change the naming to make it explicit that it is after the register though
>> so as to leave room for this to be added in future.
> 
> Some devices apparently use an entire byte or word with a magic flag in
> it to distinguish reads and writes.  These end up looking like 16 bit
> registers with only the lower 8 bits actually used in the current code.
Ah, fair enough there is a use case.  Can we add this as an additional patch
when needed?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/