Re: [PATCH v3] HID: Add full support for Logitech Unifying receivers

From: Dmitry Torokhov
Date: Fri Sep 09 2011 - 14:28:16 EST


On Thu, Sep 01, 2011 at 02:43:32PM +0200, Benjamin Tissoires wrote:
> > +
> > +       usbhid_submit_report(dj_rcv_hiddev, &report, USB_DIR_OUT);
>
> This is not working when the receiver is paired to a keyboard. When
> the session launches, Gnome try to send leds commands to the keyboard
> and this results in an oops.
>
> Using a pointer to the struct hid_report solves the crash.
>
> However, Dmitry, you told us about a DMA stack problem. Can you give
> us a better way to handle that?
>

Actually it is OK, usbhid_submit_report internally allocates DMA_safe
memory for raw report and copies the data for you.

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/