Re: [PATCH] usb: add new usb gadget for ACM and mass storage

From: Greg KH
Date: Fri Sep 09 2011 - 14:46:59 EST


On Fri, Sep 09, 2011 at 12:20:53PM +0200, Michal Nazarewicz wrote:
> >On Thu, Sep 08, 2011 at 08:24:47PM +0200, Klaus Schwarzkopf wrote:
> >>This driver provides two functions in one configuration:
> >>a mass storage, and a CDC ACM (serial port) link.
> >>Heavily based on multi.c and cdc2.c
>
> On Thu, 08 Sep 2011 21:11:46 +0200, Greg KH <gregkh@xxxxxxx> wrote:
> >I thought the "composite" framework make it so that drivers like this
> >were no longer needed. Or am I mistaken somehow?
>
> No. Composite framework only makes it relatively simple to create such
> gadgets, but one still needs some glue that binds all the functions into
> a single gadget.

Ah, so this is that glue?

> This seems like both a blessing and a curse (which I haven't realise when
> I was creating g_multi) since with n functions implemented one can easily
> came up with 2^n gadgets.

So we can expect more patches like this adding all of the possible
permutations of the different gadget devices?

If so, ick, I thought that the work that was done was to prevent this
from happening, oh well :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/