Re: [PATCH 1/5 resend] Fix sparse warnings

From: Greg KH
Date: Fri Sep 09 2011 - 16:47:08 EST


On Fri, Sep 09, 2011 at 01:19:35PM -0400, Nitin Gupta wrote:
> Fixes sparse warning:
> zram_drv.c:666:6: warning: symbol 'zram_slot_free_notify' was not
> declared. Should it be static?
>
> Also, max_zpage_size is now size_t just to be consistent with data-type
> of other variables maintaining sizes of various kinds.
>
> Signed-off-by: Nitin Gupta <ngupta@xxxxxxxxxx>
> ---
> drivers/staging/zram/zram_drv.c | 3 ++-
> drivers/staging/zram/zram_drv.h | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)

Close, but can you please resend the series with a proper Subject: line
that shows what subsystem/driver this is for? I explained how to do
this properly in a prior email.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/