Re: [PATCH] arch/x86/mm/init_32.c: quiet sparse noise; localfunctions should be static

[Tejun Heo]

On Fri, Sep 09, 2011 at 04:09:23PM -0700, H Hartley Sweeten wrote:
> Local functions should be marked static.  This quiets the following
> sparse noise:
> 
> warning: symbol 'lowmem_pfn_init' was not declared. Should it be static?
> warning: symbol 'highmem_pfn_init' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers,com>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Yinghai Lu <yinghai@xxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx> 

Looks good to me.

 Reviewed-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/