Re: [PATCH 1/2] block: export __make_request

From: Christoph Hellwig
Date: Mon Sep 12 2011 - 09:38:31 EST


On Mon, Sep 12, 2011 at 02:26:52PM +0200, Jens Axboe wrote:
> > What happens to the existing blk_make_request?
>
> I ended up naming __make_request() blk_queue_bio() instead.

I really hate naming things different from the method they are
implementing. I've tried to figure out what the point of the
old blk_make_request is - why would we not go through
generic_make_request for this?

Boaz, any idea?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/