Re: [PATCH] lib/sha1.c: quite sparse noise about symbol notdeclared

[msb]

+cc linux-crypto, herbert, davem, torvalds

H Hartley Sweeten (hartleys@xxxxxxxxxxxxxxxxxxx) wrote:
> Include <linux/cryptohash.h> to pickup the declarations for sha_transform
> and sha_init to quite the sparse noise:
> 
> warning: symbol 'sha_transform' was not declared. Should it be static?
> warning: symbol 'sha_init' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Mandeep Singh Baines <msb@xxxxxxxxxxxx>
> 

Acked-by: Mandeep Singh Baines <msb@xxxxxxxxxxxx>

Thanks.

> ---
> 
> diff --git a/lib/sha1.c b/lib/sha1.c
> index f33271d..1de509a 100644
> --- a/lib/sha1.c
> +++ b/lib/sha1.c
> @@ -8,6 +8,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/bitops.h>
> +#include <linux/cryptohash.h>
>  #include <asm/unaligned.h>
>  
>  /*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/