[PATCH v3] acpi: Fix CPU hot removal problem

From: canquan.shen
Date: Tue Sep 13 2011 - 22:19:06 EST


We run linux as a guest in Xen environment. When we used the xen tools
(xm vcpu-set <n>) to hot add and remove vcpu to and from the guest, we
encountered the failure on vcpu removal. We found the reason is that it
didn't go to really remove cpu in the cpu removal code path.

This patch adds acpi_bus_trim in acpi_process_hotplug_notify to fix this
issue. With this patch, it works fine for us.

Signed-off-by: Shen canquan <shencanquan@xxxxxxxxxx>
---
drivers/acpi/processor_driver.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
index a4e0f1b..0856ef8 100644
--- a/drivers/acpi/processor_driver.c
+++ b/drivers/acpi/processor_driver.c
@@ -677,6 +677,13 @@ static void acpi_processor_hotplug_notify(acpi_handle handle,
"Driver data is NULL, dropping EJECT\n");
return;
}
+ ACPI_DEBUG_PRINT((ACPI_DB_INFO,
+ "Hot-removing processor device %s\n",
+ dev_name(&device->dev)));
+ if (acpi_bus_trim(device, 1)) {
+ printk(KERN_ERR "ACPI: Removing device failed!\n");
+ return;
+ }
break;
default:
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
--
1.7.6.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/