Re: [PATCH] USB: ehci-pci: Check and enable wakeup capability

From: Alan Stern
Date: Wed Sep 14 2011 - 11:02:28 EST


On Tue, 13 Sep 2011, Sameer Nanda wrote:

> If the PORTWAK register is implemented and at least one of the physical
> ports is enabled for wakeup, enable wakeup for the ehci-pci device.

NAK. Our current policy is that devices do not get enabled for wakeup
by default unless users expect it (things like keyboards and power
buttons, maybe LAN interfaces).

One certainly can question this policy. It might make sense to enable
wakeup for devices that don't generate wakeup events on their own but
merely act as bridges for other devices. By this reasoning, all USB
host controllers should always be enabled for wakeup by default -- not
just some of the PCI-based controllers. But this is a separate matter
and should be discussed on the mailing list.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/