Re: [PATCH/RFC] parport_pc: remove ancient, overeager quirk thatdisables EPP support on many chipsets

From: Greg KH
Date: Thu Sep 15 2011 - 06:17:25 EST


On Thu, Sep 15, 2011 at 11:33:18AM +0200, Leopold Palomo-Avellaneda wrote:
> Hi,
>
> there's a bug in the parport module that have been reported (in another
> places) some time ago [1]. Also, this bug was reported at Redhat [2], but
> nobody follow the report and it was closed.
>
> As Adam baked said [1] :
>
> <quote>
> A long time ago (~ 10 years), Intel produced a chipset that
> included broken EPP support. The Linux parport driver was written to detect
> such a chipset and disable EPP support on it. Unfortunately the test that was
> written gives false positives for many current chipsets and no-one seems to
> know exactly what the problem hardware was, let alone have a sample of it to
> see if a better test can be written. After such a long time it is probably
> appropriate to just remove the test (on average it does more harm than good)
> however you are correct in asserting the driver is unmaintained so no-one is
> bothering to fix it.
> </quote>
>
> I have applied the patch to the standard debian kernel and vanilla kernels and
> runs perfectly. The patch simply erases a check. Applied to some Dell
> hardware, now the EPP mode is detected and, after some initial tests it's
> working.
>
> Please, apply the patch.

Please resend it with the proper Signed-off-by: line, as described by
Documentation/SubmittingPatches and we will be glad to consider it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/