Re: [RFC v3] arm: Add platform bus driver for memory mapped virtiodevice

From: Anthony Liguori
Date: Mon Sep 19 2011 - 09:28:45 EST


On 09/18/2011 10:29 PM, Rusty Russell wrote:
On Fri, 16 Sep 2011 12:01:49 -0500, Anthony Liguori<aliguori@xxxxxxxxxx> wrote:
On 09/16/2011 11:47 AM, Pawel Moll wrote:
This patch, based on virtio PCI driver, adds support for memory
mapped (platform) virtio device. This should allow environments
like qemu to use virtio-based block& network devices.

One can define and register a platform device which resources
will describe memory mapped control registers and "mailbox"
interrupt. Such device can be also instantiated using the Device
Tree node with compatible property equal "virtio,mmio".

Cc: Rusty Russell<rusty@xxxxxxxxxxxxxxx>
Cc: Anthony Liguori<aliguori@xxxxxxxxxx>
Cc: Michael S.Tsirkin<mst@xxxxxxxxxx>
Signed-off-by: Pawel Moll<pawel.moll@xxxxxxx>

Have you written a specification for this device?

Rusty maintains a formal spec for all virtio devices at:

http://ozlabs.org/~rusty/virtio-spec/

The spec should be written before merging the code to make sure that there
aren't future compatibility problems.

A good idea, but the current spec is for PCI. I wonder if we should
move the PCI part out to an appendix and make it more general?

Meanwhile, perhaps this would be suitable as an appendix.

I was thinking an appendix would be a good start.

Regards,

Anthony Liguori


Cheers,
Rusty.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/