RE: [PATCH V10 3/6] mm: frontswap: core frontswap functionality

[Dan Magenheimer]

> From: Seth Jennings [mailto:sjenning@xxxxxxxxxxxxxxxxxx]
> Sent: Friday, September 16, 2011 9:12 AM
> To: Dan Magenheimer
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; jeremy@xxxxxxxx; hughd@xxxxxxxxxx;
> ngupta@xxxxxxxxxx; Konrad Wilk; JBeulich@xxxxxxxxxx; Kurt Hackel; npiggin@xxxxxxxxx; akpm@linux-
> foundation.org; riel@xxxxxxxxxx; hannes@xxxxxxxxxxx; matthew@xxxxxx; Chris Mason;
> kamezawa.hiroyu@xxxxxxxxxxxxxx; jackdachef@xxxxxxxxx; cyclonusj@xxxxxxxxx; levinsasha928@xxxxxxxxx
> Subject: Re: [PATCH V10 3/6] mm: frontswap: core frontswap functionality
> 
> On 09/15/2011 04:34 PM, Dan Magenheimer wrote:
> > From: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
> > Subject: [PATCH V10 3/6] mm: frontswap: core frontswap functionality
> >
> > [v10: sjenning@xxxxxxxxxxxxxxxxxx: fix debugfs calls on 32-bit]
> ...
> > +#ifdef CONFIG_DEBUG_FS
> > +	struct dentry *root = debugfs_create_dir("frontswap", NULL);
> > +	if (root == NULL)
> > +		return -ENXIO;
> > +	debugfs_create_u64("gets", S_IRUGO, root, &frontswap_gets);
> > +	debugfs_create_u64("succ_puts", S_IRUGO, root, &frontswap_succ_puts);
> > +	debugfs_create_u64("puts", S_IRUGO, root, &frontswap_failed_puts);
> 
> Sorry I didn't see this one before :-/  This should be "failed_puts",
> not "puts".

Oops, thought I had replied to this but hadn't.

Thanks for catching that typo.  Unless someone reports something
else that needs fixing, I will likely just fix that in my git tree
rather than post a V11.
 
> Other than that, it compiles cleanly here and runs without issue when
> applied on 3.1-rc4 + fix for cleancache crash.

Thanks for the testing!

Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/