Re: [V5][PATCH 4/6] x86, nmi: add in logic to handle multiple eventsand unknown NMIs

From: Avi Kivity
Date: Wed Sep 21 2011 - 01:45:53 EST


On 09/20/2011 11:10 PM, Don Zickus wrote:
On Tue, Sep 20, 2011 at 08:23:03PM +0300, Avi Kivity wrote:
> >V4:
> > - clean up fixes, like adding 'static', rename save_rip to last_nmi_rip
> >
> >
>
> Missing a zeroing of last_nmi_rip in the idle path. Otherwise, as
> Andi points out, and idle machine will always see NMIs coming in
> from the hlt/mwait address and detect them as back-to-back NMIs.

You mean something like this?


Yes.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/