Re: [PATCH] x86_64: permit to configure ISA support also for x86_64systems

From: Wolfgang Grandegger
Date: Wed Sep 21 2011 - 04:33:16 EST


On 09/20/2011 05:47 PM, Arnd Bergmann wrote:
> On Friday 16 September 2011, Wolfgang Grandegger wrote:
>> On 09/16/2011 09:19 PM, Valdis.Kletnieks@xxxxxx wrote:
>>> On Fri, 16 Sep 2011 11:22:45 +0200, Wolfgang Grandegger said:
>>>> There are 64-bit systems out there, like the ATOM N450, which
>>>> have ISA slots.
>>>
>>> That's a scary thought...
>>
>> Well. Actually we need it for Intel Atom N450 PC/104-Plus SBCs.
>
> I would assume that you have a small set of ISA add-on cards that
> you actually need to support, right?

Yes, various PC/104 compatible boards can be connected to the ISA bus on
such systems (via PC/104 connector). I personally do only care about the
CAN devices (as maintainer).

> Since most ISA drivers don't actually use isa_register_driver
> (for good or bad), how about changing the Kconfig entry for
> the ones you need to 'depends on ISA || PLAT_GRANDEGGER_PC104_ATOM'
> or similar?

What should the PLAT_GRANDEGGER_PC104_ATOM be good for? If I replace
isa_register_driver() with platform_driver_register(), like the serial
8250 driver does, HAS_IOMEM should be just fine. This would then also
avoid the 64-bit trouble expected with old ISA drivers (enabled via
ISA). Or have I missed something?

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/