Re: [PATCH] user namespace: make signal.c respect user namespaces

[Oleg Nesterov]

On 09/20, Serge E. Hallyn wrote:
>
> Quoting Oleg Nesterov (oleg@xxxxxxxxxx):
> > On 09/19, Serge E. Hallyn wrote:
> > >
> > > __send_signal: convert the uid being sent in SI_USER to the target task's
> > > user namespace.
> > >
> > > do_notify_parent and do_notify_parent_cldstop: map task's uid to parent's
> > >  user namespace
> > >
> > > ptrace_signal: map parent's uid into current's user namespace before
> > > including in signal to current.
> >
> > Btw, what about the other users of ->si_uid? Say, kill() or tkill().
>
> Well, they end up calling __send_signal().

Sure. But your patch changes only the __send_signal(SEND_SIG_NOINFO).
Note that SEND_SIG_NOINFO is rarely used, and only by kernel.

> But you sound more alarmed than that.

I am ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/