Re: [PATCH] x86_64: permit to configure ISA support also for x86_64systems

[Wolfgang Grandegger]

On 09/22/2011 04:20 PM, Arnd Bergmann wrote:
> On Thursday 22 September 2011, Wolfgang Grandegger wrote:
>> On 09/21/2011 11:24 AM, Arnd Bergmann wrote:
>>> On Wednesday 21 September 2011 10:33:10 Wolfgang Grandegger wrote:
>>> The other point is that you are probably using inb/outb operations,
>>> which I'm trying to provide only on ISA/PCMCIA/PCI based systems in
>>> the future. Once I finish that work, you will also need to depend on
>>> HAS_IOPORT (which currently means something else).
>>
>> OK, the sja1000_isa driver just uses memory mapped access.
> 
> According to this it uses both PIO and MMIO:
> 
> $ git grep '\(in\|out\|read\|write\)\(b\|w\|l\)' drivers/net/can/sja1000/sja1000_isa.c 
> drivers/net/can/sja1000/sja1000_isa.c:  return readb(priv->reg_base + reg);
> drivers/net/can/sja1000/sja1000_isa.c:  writeb(val, priv->reg_base + reg);
> drivers/net/can/sja1000/sja1000_isa.c:  return inb((unsigned long)priv->reg_base + reg);
> drivers/net/can/sja1000/sja1000_isa.c:  outb(val, (unsigned long)priv->reg_base + reg);
> drivers/net/can/sja1000/sja1000_isa.c:  outb(reg, base);
> drivers/net/can/sja1000/sja1000_isa.c:  return inb(base + 1);
> drivers/net/can/sja1000/sja1000_isa.c:  outb(reg, base);
> drivers/net/can/sja1000/sja1000_isa.c:  outb(val, base + 1);

Ah, oh, I forgot. The driver supports both, I/O port and memory mapped
access.

> But don't worry about it, I'll make the right Kconfig annotation when I submit my
> patches.

OK,

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/