Re: [PATCH] gma500: gtt based hardware scrolling console

[Geert Uytterhoeven]

Hi Alan,

On Thu, Sep 22, 2011 at 20:43, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
diff --git a/drivers/staging/gma500/framebuffer.c
b/drivers/staging/gma500/framebuffer.c
index 7748331..3f39a37 100644
--- a/drivers/staging/gma500/framebuffer.c
+++ b/drivers/staging/gma500/framebuffer.c

> @@ -416,6 +473,8 @@ static int psbfb_create(struct psb_fbdev *fbdev,
>
> Â Â Â Âinfo->fix.smem_start = dev->mode_config.fb_base;
> Â Â Â Âinfo->fix.smem_len = size;
> + Â Â Â info->fix.ywrapstep = gtt_roll;

Do you really want to set this? I didn't see any other wrapping
support in your patch.
However, I guess you can implement wrapping support using the same
mapping trick?

> + Â Â Â info->fix.ypanstep = gtt_roll;
>
> Â Â Â Âif (backing->stolen) {
> Â Â Â Â Â Â Â Â/* Accessed stolen memory directly */

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/