Re: [PATCH 0/3] Replace kmalloc with vmalloc in seq_files

From: Peter Zijlstra
Date: Thu Sep 22 2011 - 17:23:18 EST


On Thu, 2011-09-22 at 13:57 -0700, Colin Cross wrote:
>
> seq_files are often used for debugging data. When the system is under
> memory pressure, and dumping debugging data starts trying to allocate
> large physically contiguous buffers, it often makes the problem
> worse.

Shouldn't you be using ->next instead of dumping everything in a single
seqop? That way it can return partial buffers and keep state etc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/