Re: [PATCH] tty/n_gsm: fix bug in tiocmset

From: Alan Cox
Date: Fri Sep 23 2011 - 06:06:54 EST


On Fri, 23 Sep 2011 10:59:43 +0200
Nikola Diklic-Perin <diklic.perin.nikola@xxxxxxxxx> wrote:

> From: Nikola Diklic-Perin <diklic.perin.nikola@xxxxxxxxx>
>
> Clear bitmask was not inverted before masking modem_tx.
>
> Calling ioctl(fd, TIOCMBIC, TIOCM_RTS) results in:
>
> [ 197.430000] pre_modem_tx: 0x00000006
> [ 197.430000] clear: 0x00000004
> [ 197.430000] set: 0x00000000
> [ 197.440000] post_modem_tx: 0x00000004
>
> which is wrong.
>
> Signed-off-by: Nikola Diklic-Perin <diklic.perin.nikola@xxxxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/