Re: [PATCH 07/10] drbd: Remove headers from on-the-wire datastructures (struct p_*)

From: Kyle Moffett
Date: Fri Sep 23 2011 - 13:38:39 EST


Hi!

On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner@xxxxxxxxxx> wrote:
> From: Andreas Gruenbacher <agruen@xxxxxxxxxx>
>
> Signed-off-by: Philipp Reisner <philipp.reisner@xxxxxxxxxx>
> Signed-off-by: Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>
> ---
> Âdrivers/block/drbd/drbd_int.h   Â|  45 ----------
> Âdrivers/block/drbd/drbd_main.c   |  44 +++++-----
> Âdrivers/block/drbd/drbd_receiver.c | Â171 ++++++++++++++++++------------------
> Âdrivers/block/drbd/drbd_worker.c  |  Â2 +-

This commit is kind of borderline too-big for just a one-line commit message.

It is admittedly very simple (changing the same pointer math in ~50 places),
but it needs a bit more explanation about why it's helpful or necessary.

I *think* it's because the protocol-100 code will use a different-sized header,
but that needs to be actually explained somewhere.

Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/