Re: [PATCH] x86: use the same node_distance for 32 and 64-bit

From: Tejun Heo
Date: Fri Sep 23 2011 - 21:45:53 EST


On Mon, Sep 19, 2011 at 04:03:14PM -0700, H Hartley Sweeten wrote:
> The node_distance function is not x86 64-bit specific. Having the #ifdef
> around the extern function declaration and the #define causes the default
> node_distance macro to be used in asm-generic/topology.h. This also causes
> a sparse warning in arch/x86/mm/numa.c when CONFIG_X86_64 is not set:
>
> warning: symbol '__node_distance' was not declared. Should it be static?
>
> Remove the #ifdef to fix both issues.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Yinghai Lu <yinghai@xxxxxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thank you.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/