Re: [PATCH] perf tools: Fix tracing info recording

[Jiri Olsa]

On Wed, Sep 21, 2011 at 05:30:24PM +0200, Frederic Weisbecker wrote:
> On Wed, Sep 14, 2011 at 03:58:40PM +0200, Jiri Olsa wrote:
> > The tracing information is part of the perf data file. It contains
> > several files from within the tracing debugfs and procs directories.
> > 
> > Beside some static header files, for each tracing event the format
> > file is added. The /proc/kallsyms file is also added.
> > 
> > The tracing data are stored with preceeding size. This is causing some
> > dificulties for pipe output, since there's no way to tell debugfs/proc
> > file size before reading it. So, for pipe output, all the debugfs files
> > were read twice. Once to get the overall size and once to store the
> > content itself. This can cause problem in case any of these file
> > changed, within the storage time.
> > 
> > Fixing this behaviour by using temp file in case of pipe output. The
> > debugfs/proc files are being read only once, ensuring the integrity of
> > the tracing data.
> > 
> > Also changing the way the event files are searched by quering specified
> > event files directly, instead of walking the events directory.
> > 
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> 
> Looks good overall, but I have some comments about details:

hi,
thanks for comments,
I'll make the changes and send out new version soon

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/