Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

[KyongHo Cho]

On Tue, Sep 27, 2011 at 5:48 PM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index d084e87..2987199 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -98,11 +98,12 @@ extern void iommu_set_fault_handler(struct
> iommu_domain *domain,
>  * Returns 0 on success and an appropriate error code otherwise (if dynamic
>  * PTE/TLB loading will one day be supported, implementations will be able
>  * to tell whether it succeeded or not according to this return value).
> + * If a fault handler isn't installed, -ENOSYS is returned.
>  */
>  static inline int report_iommu_fault(struct iommu_domain *domain,
>                struct device *dev, unsigned long iova, int flags)
>  {
> -       int ret = 0;
> +       int ret = -ENOSYS;
>
>        /*
>         * if upper layers showed interest and installed a fault handler,
It looks good for me.

I will prepare new patches with the changed API.

Thank you.
Cho KyongHo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/