Re: [PATCH] user namespace: make signal.c respect user namespaces

From: Oleg Nesterov
Date: Tue Sep 27 2011 - 13:16:26 EST


On 09/27, Serge Hallyn wrote:
>
> Quoting Oleg Nesterov (oleg@xxxxxxxxxx):
> >
> > ptrace_signal() simply fills *info with some "random" data before
> > processing the signal. It doesn't pass this info to send_signal().
>
> Oh, well not always, but it does in the case where
> sigismember(&current->blocked, signr);

Ah, thanks, now I see what you mean.

> But I suppose that's not a common path :)

Yes. And, in this case the task "sends" a signal to itself. This means,
whatever we do with __send_signal() it shouldn't change info->si_uid.
(At least with fixup_uid() I suggested).

I am glad we finally understand each other, most probably I didn't read
your previous emails carefully ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/