Re: [RFD 4/9] Make total_forks per-cgroup

[Peter Zijlstra]

On Fri, 2011-09-23 at 19:20 -0300, Glauber Costa wrote:
> @@ -1039,6 +1035,8 @@ static void posix_cpu_timers_init(struct task_struct *tsk)
>         INIT_LIST_HEAD(&tsk->cpu_timers[2]);
>  }
>  
> +struct task_group *task_group(struct task_struct *p);

That doesn't appear to be actually used in this file..

Also, since there's already a for_each_possible_cpu() loop in that
proc/stat function, would it yield some code improvement to make
total_forks a cpu_usage_stat?

I guess the whole cputime64_t crap gets in the way of that being
natural... 

We could of course kill off the cputime64_t thing, its pretty pointless
and its a u64 all over the board. I think Martin or Heiko created this
stuff (although I might be wrong, my git tree doesn't go back that far).


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/