Re: [PATCH v3 20/24] C6X: library code

[Arnd Bergmann]

On Tuesday 27 September 2011, Mark Salter wrote:
> +++ b/arch/c6x/include/asm/checksum.h
> @@ -0,0 +1,115 @@
> +/*
> + *  Port on Texas Instruments TMS320C6x architecture
> + *
> + *  Copyright (C) 2004, 2009, 2010 Texas Instruments Incorporated
> + *  Author: Aurelien Jacquiot (aurelien.jacquiot@xxxxxxxxxx)
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License version 2 as
> + *  published by the Free Software Foundation.
> + */
> +#ifndef _ASM_C6X_CHECKSUM_H
> +#define _ASM_C6X_CHECKSUM_H
> +
> +#include <asm/byteorder.h>

I think you should fall back on the generic checksum.h file and only
provide the declarations that are different. This file is largely
identical to the generic version.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/