Re: [RFD 1/9] Change cpustat fields to an array.

From: Glauber Costa
Date: Wed Sep 28 2011 - 11:14:58 EST


On 09/27/2011 06:03 PM, Peter Zijlstra wrote:
On Fri, 2011-09-23 at 19:20 -0300, Glauber Costa wrote:
@@ -623,6 +624,9 @@ static inline struct task_group *task_group(struct
task_struct *p)
struct task_group *tg;
struct cgroup_subsys_state *css;

+ if (!p->mm)
+ return&root_task_group;
+
css = task_subsys_state_check(p, cpu_cgroup_subsys_id,
lockdep_is_held(&p->pi_lock) ||
lockdep_is_held(&task_rq(p)->lock));

Hmm, why is that? Aren't kthreads part of the cgroup muck just as much
as normal tasks are?
You're right. I had something else from another work I'm doing in mind and got confused.
Will remove it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/