Re: [PATCH 2/4] cifs, freezer: add wait_event_freezekillable andhave cifs use it

From: Jeff Layton
Date: Thu Sep 29 2011 - 13:27:38 EST


On Thu, 29 Sep 2011 11:39:53 -0500
Steve French <smfrench@xxxxxxxxx> wrote:

> On Thu, Sep 29, 2011 at 5:41 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> > On Wed, 28 Sep 2011 23:28:02 -0500
> > Steve French <smfrench@xxxxxxxxx> wrote:
> >
> >> The general idea of the patch seems like a good idea to
> >> me. ÂAssuming testing feedback was good from the problem
> >> reporters, what tree would you want it merged from?
> >>
> >
> > There's the rub -- this requires a number of changes in different
> > areas. What I really need at this point is a verdict on patch #1. If
> > that looks OK, then that should probably go in via the one of the
> > linux-pm trees. Then patch #2 can probably go in via your tree and 3
> > and 4 can go in via Trond's.
>
> Yes - makes sense, but wonder about ways to test the various
> suspend/hibernate cases to make sure they work.
>

I think this set is unlikely to hurt anything (assuming of course that
waking up TASK_KILLABLE tasks on suspend events is OK). It's possible
that there are other places that need to be patched in the same way,
but this seems to cover the main pain points that people have reported.

--
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/