Re: [PATCH 1/2] leds-class: change back LEDS_CLASS to tristateinstead of bool

[Bryan Wu]

On Thu, Sep 29, 2011 at 4:07 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Mon, Sep 05, 2011 at 08:51:38PM +0100, Richard Purdie wrote:
>> On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
>> > LEDS_CLASS is required by leds and trigger drivers, but we can build it
>> > as module. So change this option back as tristate and treak the help
>> > message as well.
>> >
>> > Signed-off-by: Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
>>
>> Acked-by: Richard Purdie <rchard.purdie@xxxxxxxxxxxxxxxxxxx>
>>
>> > ---
>> >  drivers/leds/Kconfig |    7 +++++--
>> >  1 files changed, 5 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> > index b591e72..1c35927 100644
>> > --- a/drivers/leds/Kconfig
>> > +++ b/drivers/leds/Kconfig
>> > @@ -17,10 +17,13 @@ menuconfig NEW_LEDS
>> >  if NEW_LEDS
>> >
>> >  config LEDS_CLASS
>> > -   bool "LED Class Support"
>> > +   tristate "LED Class Support"
>> >     help
>> >       This option enables the led sysfs class in /sys/class/leds.  You'll
>> > -     need this to do anything useful with LEDs.  If unsure, say N.
>> > +     need this to do anything useful with LEDs.  If unsure, say M.
>> > +
>> > +     Note: don't disable it as N, because plenty of led and trigger drivers
>> > +     are using this option.
>
> This is crap - putting a dependency in the help for an option is
> unacceptable when we have things like randconfig etc which are
> expected to work.
>
> If this must be 'm' or 'y', then make it depend on m to force the
> minimum setting.
>

I will remove the pointless help message and try to fix all compiling
error then, and send out the patch again.

Thanks,
-- 
Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/