Re: [PATCH 7/8] staging: et131x: Updating copyright statements andmodule authors

[Dan Carpenter]

On Sat, Oct 01, 2011 at 11:14:16AM +0100, Mark Einon wrote:
> @@ -945,5 +947,6 @@ module_exit(et131x_cleanup_module);
>  
>  /* Modinfo parameters (filled out using defines from et131x_version.h) */
>  MODULE_AUTHOR(DRIVER_AUTHOR);
> +MODULE_AUTHOR(DRIVER_AUTHOR2);
>  MODULE_DESCRIPTION(DRIVER_INFO);
>  MODULE_LICENSE(DRIVER_LICENSE);

Both DRIVER_AUTHOR and DRIVER_AUTHOR2 are silly macros.  Put the name
in directly.  That way you won't need the comment explaining where to
find the definitions.  Also normally people use gt lt brackets for
emails:

MODULE_AUTHOR("Victor Soriano <vjsoriano@xxxxxxxxx>");
MODULE_AUTHOR("Mark Einon <mark.einon@xxxxxxxxx>");

Go ahead and fix this in a later patch if you want.  All the macros
there should probably be replaced.

Btw, the problems with kernel.org have complicated things here, so
I can't tell if you have already fixed this, but the driver doesn't
compile any more.  The Kconfig file says it "depends on NETDEV_1000"
but NETDEV_1000 isn't around any more since f860b0522f65d3
"drivers/net: Kconfig and Makefile cleanup" was merged.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/