Re: [PATCH 7/8] staging: et131x: Updating copyright statements andmodule authors

From: Mark Einon
Date: Sun Oct 02 2011 - 14:54:33 EST

On 1 October 2011 20:58, Dan Carpenter <dan.carpenter@xxxxxxxxxx>
wrote:> On Sat, Oct 01, 2011 at 11:14:16AM +0100, Mark Einon wrote:>>
@@ -945,5 +947,6 @@ module_exit(et131x_cleanup_module);>>>>  /*
Modinfo parameters (filled out using defines from et131x_version.h)
DRIVER_AUTHOR2 are silly macros.  Put the name> in directly.  That way
you won't need the comment explaining where to> find the definitions.
Also normally people use gt lt brackets for> emails:>>
MODULE_AUTHOR("Victor Soriano <vjsoriano@xxxxxxxxx>");>
MODULE_AUTHOR("Mark Einon <mark.einon@xxxxxxxxx>");>> Go ahead and fix
this in a later patch if you want.  All the macros> there should
probably be replaced.
Hi Dan, thanks for the feedback.Removing et131x_version.h file and
simplifying the macros is alreadyon my todo list.
>> Btw, the problems with have complicated things here, so> I can't tell if you have already fixed this, but the driver doesn't> compile any more.  The Kconfig file says it "depends on NETDEV_1000"> but NETDEV_1000 isn't around any more since f860b0522f65d3> "drivers/net: Kconfig and Makefile cleanup" was merged.>
No, I've not experienced this issue yet. I'm using Greg's
staging-2.6tree, last updated at 7cbf3c7cd59 which doesn't have the
commit youmention.I'll look out for it when everything gets moving
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at