[PATCH 07/10] Report steal time for cgroup

From: Glauber Costa
Date: Sun Oct 02 2011 - 15:23:03 EST


This patch introduces a functionality commonly found in
hypervisors: steal time.

For those not particularly familiar with it, steal time
is defined as any time in which a virtual machine (or container)
wanted to perform cpu work, but could not due to another
VM/container being scheduled in its place. Note that idle
time is never defined as steal time.

Assuming each container will live in its cgroup, we can
very easily and nicely calculate steal time as all user/system
time recorded in our sibling cgroups.

Signed-off-by: Glauber Costa <glommer@xxxxxxxxxxxxx>
---
kernel/sched.c | 28 ++++++++++++++++++++++++++++
1 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index a2554b7..dec73c4 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -9175,6 +9175,7 @@ int cpu_cgroup_proc_stat(struct cgroup *cgrp, struct cftype *cft,
struct timespec boottime;
#ifdef CONFIG_CGROUP_SCHED
struct task_group *tg;
+ struct task_group *sib;

if (cgrp)
tg = cgroup_tg(cgrp);
@@ -9215,6 +9216,20 @@ int cpu_cgroup_proc_stat(struct cgroup *cgrp, struct cftype *cft,
guest += kstat->cpustat[GUEST];
guest_nice += kstat->cpustat[GUEST_NICE];
total_forks += kstat->cpustat[TOTAL_FORKS];
+ steal += kstat->cpustat[STEAL];
+#ifdef CONFIG_CGROUP_SCHED
+ rcu_read_lock();
+ list_for_each_entry(sib, &tg->siblings, siblings) {
+ struct kernel_stat *ksib;
+ if (!sib)
+ continue;
+
+ ksib = per_cpu_ptr(sib->cpustat, i);
+ steal += ksib->cpustat[USER] + ksib->cpustat[SYSTEM] +
+ ksib->cpustat[IRQ] + ksib->cpustat[SOFTIRQ];
+ }
+ rcu_read_unlock();
+#endif
sum += kstat_cpu_irqs_sum(i);
sum += arch_irq_stat_cpu(i);

@@ -9260,6 +9275,19 @@ int cpu_cgroup_proc_stat(struct cgroup *cgrp, struct cftype *cft,
irq = kstat->cpustat[IRQ];
softirq = kstat->cpustat[SOFTIRQ];
steal = kstat->cpustat[STEAL];
+#ifdef CONFIG_CGROUP_SCHED
+ rcu_read_lock();
+ list_for_each_entry(sib, &tg->siblings, siblings) {
+ struct kernel_stat *ksib;
+ if (!sib)
+ continue;
+
+ ksib = per_cpu_ptr(sib->cpustat, i);
+ steal += ksib->cpustat[USER] + ksib->cpustat[SYSTEM] +
+ ksib->cpustat[IRQ] + ksib->cpustat[SOFTIRQ];
+ }
+ rcu_read_unlock();
+#endif
guest = kstat->cpustat[GUEST];
guest_nice = kstat->cpustat[GUEST_NICE];
seq_printf(p,
--
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/