Re: [PATCH 5/6] ASoC: samsung: fix Kconfig dependencies
From: Mark Brown
Date: Sun Oct 02 2011 - 16:47:45 EST
On Sun, Oct 02, 2011 at 10:28:03PM +0200, Arnd Bergmann wrote:
> config SND_SAMSUNG_AC97
> + depends on SND_SOC_ALL_CODECS=n || SND_SOC_ALL_CODECS
> select SND_SOC_AC97_BUS
No, I'm not sure what the problem you're trying to fix here but this
looks pretty terrible. SND_SOC_ALL_CODECS is a debugging tool for build
coverage, we shouldn't be restricting actual useful drivers based on it.
What is the intention of this change and why does it only apply to the
Samsung platform? It all looks very magic.
> config SND_SOC_SAMSUNG_SMDK_WM8994
> tristate "SoC I2S Audio support for WM8994 on SMDK"
> depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210)
> + depends on MFD_WM8994
> select SND_SOC_WM8994
This is non-idiomatic - we always select the CODEC drivers rather than
depending on them for usability.
Please also split the two changes you're doing here into separate
patches. I might've applied the wm8994 bit but it's squashed in with
the AC'97 change...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/