Re: [BUGFIX] cgroup: create a workqueue for cgroup
From: Daisuke Nishimura
Date: Mon Oct 03 2011 - 01:23:42 EST
On Mon, 3 Oct 2011 09:22:44 +0900
Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> wrote:
> On Fri, 30 Sep 2011 15:30:49 -0700
> Andrew Morton <akpm00@xxxxxxxxx> wrote:
> > On Fri, 30 Sep 2011 16:54:52 +0900
> > Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> wrote:
> > > In commit:f90d4118, cpuset_wq, a separate workqueue for cpuset, was introduced
> > > to avoid a dead lock against cgroup_mutex between async_rebuild_sched_domains()
> > > and cgroup_tasks_write().
> > >
> > > But check_for_release() has a similar problem:
> > >
> > > check_for_release()
> > > schedule_work(release_agent_work)
> > > cgroup_release_agent()
> > > mutex_lock(&cgroup_mutex)
> > >
> > > And I actually see a lockup which seems to be caused by this problem
> > > on 2.6.32-131.0.15.el6.x86_64.
> > Are you sure the bug is still present in current kernels? Perhaps
> > Tejun's workqueue changes magically made it go away.
> Not yet, but I'll check it.
As you said, I cannot repricate this issue on 3.1-rc8. But I've verified
it happens on 188.8.131.52 and this patch fixes it, so I think this patch is
necessary for stable at least.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/