Re: One comment on the __release_region in kernel/resource.c
From: Geert Uytterhoeven
Date: Mon Oct 03 2011 - 07:15:12 EST
On Mon, Oct 3, 2011 at 12:24, KAMEZAWA Hiroyuki
> On Sun, 2 Oct 2011 21:57:07 +0800
> Wei Yang <weiyang.kernel@xxxxxxxxx> wrote:
>> Dear experts,
>> I am viewing the source code of __release_region() in kernel/resource.c.
>> And I have one comment for the performance issue.
>> For example, we have a resource tree like this.
>> Â Â20-79
>> Â Â Â Â30-49
>> Â Â Â Â55-59
>> Â Â Â Â60-64
>> Â Â Â Â65-69
>> Â Â80-89
>> If the caller wants to release a region of [50,59], the original code will
Do you really mean [50,59]?
I don't think that's allowed, as the tree has [55,59], so you would release a
larger region that allocated.
Â Â Â Â Â Â Â Â Â Â Â Â Geert
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
Â Â Â Â Â Â Â Â Â Â Â Â Â ÂÂ ÂÂ -- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/