Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node
From: Mark Brown
Date: Mon Oct 03 2011 - 08:40:52 EST
On Mon, Oct 03, 2011 at 01:30:15PM +0100, Daniel Drake wrote:
> On Mon, Oct 3, 2011 at 1:16 PM, Mark Brown
> > It seems to me like either the IP block is heavily dependant on the core
> > and shouldn't be split out in the device tree at all (but should instead
> > be part of the core node) or the IP block is very isolated from the core
> > (in which case we should just be able to instantiate the device from the
> > device tree without using explict code in the core driver).
> > This all feels like there's some abstraction violation going on.
> I guess it is a matter of opinion. To me, the abstraction is sensible
> and representative of the hardware.
> This also matches the way that the hardware is described by VIA in the
> specs, and it matches the way that Linux has its own device hierachy
> laid out (i.e. the ISA bridge driven by the mfd driver, which then
> spawns off a child device for the GPIO controller).
> It would not be possible to fold all of the isa bridge child
> components into the same device tree node without dealing with various
> namespace collisions.
So, I made two suggestions above and it sounds like you want the second
one but you've only responded to the first one without commenting on the
second. My second suggestion was that if the block is sufficiently
isoltated from the core we should be able instantiate it from the device
tree without requiring explicit code in the core driver.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/