Re: [PATCH] sched/kthread: Complain loudly when others violate ourflags

From: Thomas Gleixner
Date: Mon Oct 03 2011 - 09:43:57 EST


On Mon, 3 Oct 2011, Peter Zijlstra wrote:

> On Mon, 2011-10-03 at 12:20 +0200, Peter Zijlstra wrote:
> > I didn't write this change for fun, I actually need to get
> > PF_THREAD_BOUND back to sanity, this change alone isn't enough, but it
> > gets rid of the worst abuse. This isn't frivolous perturbation.
>
> Not to mention it gets rid of ~250 lines, and it adds stricter checking
> and thereby removes the need to manually flush queues if you really
> meant things to be per-cpu.
>
> I mean, really, what's the downside?

Nothing. If code can be simplified and at the same time gets stricter
semantics and becomes less fragile then there is no valid reason to
refuse such a cleanup.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/