Re: [PATCH 1/2 v2] udf : enable error print in udf_read_tagged().

[NamJae Jeon]

2011/10/3 Joe Perches <joe@xxxxxxxxxxx>:
> On Mon, 2011-10-03 at 16:19 +0900, Namjae Jeon wrote:
>> And I use pr_fmt instead of printk by joe's suggestion. I try to modify totally it to pr_fmt also.
> []
>> diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
> []
>> @@ -19,18 +21,15 @@
>> Â#undef UDFFS_DEBUG
>>
>> Â#ifdef UDFFS_DEBUG
>> -#define udf_debug(f, a...) \
>> -do { \
>> - Â Â printk(KERN_DEBUG "UDF-fs DEBUG %s:%d:%s: ", \
>> - Â Â Â Â Â Â __FILE__, __LINE__, __func__); \
>> - Â Â printk(f, ##a); \
>> -} while (0)
>> +#define udf_debug(fmt, ...) Â\
>> + Â Â pr_debug("DEBUG %s:%d:%s: ", fmt, Â Â Â \
>> + Â Â Â Â Â Â __FILE__, __LINE__, __func__, __VA_ARGS__);
>
> This doesn't compile properly if UDFFS_DEBUG is
> #defined.
>
> No comma should be between "DEBUG %s:%d:%s: " and fmt.
Hi. Joe.
oops! it's my mistake.
I  sent v3 patch again.
Would you review one more ?
Thanks.
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/