Re: [PATCH 09/23] mfd/db8500-prcmu: tweak for modem wakeup

[Samuel Ortiz]

Hi Linus,

On Fri, Aug 12, 2011 at 10:28:43AM +0200, Linus Walleij wrote:
> @@ -1754,11 +1755,34 @@ void prcmu_ac_wake_req(void)
>  
>  	atomic_set(&ac_wake_req_state, 1);
>  
> +retry:
>  	writel((val | PRCM_HOSTACCESS_REQ_HOSTACCESS_REQ), PRCM_HOSTACCESS_REQ);
>  
>  	if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
> -			msecs_to_jiffies(20000))) {
> -		pr_err("prcmu: %s timed out (20 s) waiting for a reply.\n",
> +			msecs_to_jiffies(5000))) {
> +		panic("prcmu: %s timed out (5 s) waiting for a reply.\n",
> +			__func__);
panic(), really ?


> @@ -1783,8 +1807,8 @@ void prcmu_ac_sleep_req()
>  		PRCM_HOSTACCESS_REQ);
>  
>  	if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
> -			msecs_to_jiffies(20000))) {
> -		pr_err("prcmu: %s timed out (20 s) waiting for a reply.\n",
> +			msecs_to_jiffies(5000))) {
> +		panic("prcmu: %s timed out (5 s) waiting for a reply.\n",
Ditto.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/