Re: [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h

From: Paul Gortmaker
Date: Mon Oct 03 2011 - 12:03:40 EST

On 11-10-03 06:30 AM, Mark Brown wrote:
> On Mon, Oct 03, 2011 at 08:17:21AM +0800, Axel Lin wrote:
>> 2011/10/3 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>:
>>> What tree is this for? ?My primary development platform is based on this
>>> driver, I'd expect to have noticed any build issues and I rather suspect
>>> this isn't what you're supposed to do after all the module.h stuff has
>>> settled down.
>> I got the build error on linux-next (20110930).
> That's exactly what I'm running at the minute with no problem...

Then I'm guessing you don't have the option for it enabled (as
the s3c2410_defconfig doesn't enable it, it seems).

I reproduced it with the following commands:

28 git checkout next-20110930
29 mkdir ../arm-sam
30 make O=../arm-sam s3c2410_defconfig
31 nice make O=../arm-foo/ sound/soc/samsung/s3c-i2s-v2.o

Thanks Axel, I'll squish this into the commit that adds module.h
to all the other sound drivers that have it missing.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at