Re: [PATCH v4 4/8] per-cgroup tcp buffers control

From: Glauber Costa
Date: Tue Oct 04 2011 - 01:44:48 EST


On 10/04/2011 05:16 AM, KAMEZAWA Hiroyuki wrote:
It seems memcg->tcp.tcp_memory_pressure has no locks and not atomic.

no problematic race ?

Thanks,
-Kame
Well,

prior to this patch, it was a global variable. And nobody complained so far...

My impression is that the only thing that really needs to be atomic is
the memory accounting, which is already. If we miss a memory pressure condition entry, we'll get to it next time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/